Skip to content
This repository was archived by the owner on Feb 10, 2025. It is now read-only.

Enable and fix package:pedantic lints #62

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Enable and fix package:pedantic lints #62

merged 3 commits into from
Apr 13, 2020

Conversation

natebosch
Copy link
Contributor

  • always_declare_return_types
  • annotate_overrides
  • prefer_conditional_assignment
  • prefer_if_null_operators
  • prefer_single_quotes
  • unnecessary_this
  • use_function_type_syntax_for_parameters

Remove local lint config which duplicates enabled rules.

Ignore prefer_spread_collections for now. We should publish once more
before bumping the min SDK.

- always_declare_return_types
- annotate_overrides
- prefer_conditional_assignment
- prefer_if_null_operators
- prefer_single_quotes
- unnecessary_this
- use_function_type_syntax_for_parameters

Remove local lint config which duplicates enabled rules.

Ignore `prefer_spread_collections` for now. We should publish once more
before bumping the min SDK.
@natebosch natebosch requested a review from kevmoo April 13, 2020 18:34
Copy link
Contributor

@kevmoo kevmoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Travis is sad...

@natebosch
Copy link
Contributor Author

I forgot that the newer pedantic also has a higher min SDK.

PTAL.

@natebosch natebosch merged commit b9921fe into master Apr 13, 2020
@natebosch natebosch deleted the pedantic-lints branch April 13, 2020 19:02
mosuem pushed a commit to dart-lang/tools that referenced this pull request Dec 10, 2024
- always_declare_return_types
- annotate_overrides
- prefer_conditional_assignment
- prefer_if_null_operators
- prefer_single_quotes
- unnecessary_this
- use_function_type_syntax_for_parameters

Remove local lint config which duplicates enabled rules.

Ignore `prefer_spread_collections` for now. We should publish once more
before bumping the min SDK.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Development

Successfully merging this pull request may close these issues.

3 participants